Skip masking non-strings #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunofgs
reviewed
Sep 27, 2017
test/index_test.js
Outdated
| @@ -44,6 +45,11 @@ describe('maskXml()', () => { | |||
| `); | |||
| }); | |||
|
|
|||
| it('should skip masking non-strings', () => { | |||
| should.not.exist(maskXml(['foo', 'bar'])(undefined)); | |||
There was a problem hiding this comment.
How about this (just a readability preference):
[undefined, { biz: 'baz' }].forEach(value => {
maskXml(['foo', 'bar'])(value).should.eql(value);
})
There was a problem hiding this comment.
Fails with a TypeError: Cannot read property 'should' of undefined, but this works:
[undefined, { biz: 'baz' }].forEach(value => {
should(maskXml(['foo', 'bar'])(value)).eql(value);
});
There was a problem hiding this comment.
Fixed. Included other minor improvements too.
filipefigcorreia
force-pushed
the
enhancement/skip-masking-non-strings
branch
from
70b8eeb
to
e86fc35
Compare
nunofgs
reviewed
Sep 27, 2017
| @@ -44,6 +45,12 @@ describe('maskXml()', () => { | |||
| `); | |||
| }); | |||
|
|
|||
| it('should skip masking non-strings', () => { | |||
| [undefined, { biz: 'baz' }, 42].forEach(nonString => { | |||
| should(maskXml(['foo'])(nonString)).equal(nonString); | |||
There was a problem hiding this comment.
Use the syntax <object>.should… when possible please.
There was a problem hiding this comment.
That would also fail with a TypeError: Cannot read property 'should' of undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When providing an
undefinedparameter to the masking function (or any non-string for that matter), aTypeErroris thrown ("TypeError: Cannot read property 'replace' of undefined"). The changes introduced by this PR will make the function simply return the original parameter when it's not a string.